fix: validate duplicate language configurations in CHECKCFG#1376
Merged
joaodinissf merged 1 commit intoJul 13, 2026
Merged
Conversation
joaodinissf
force-pushed
the
fix/checkcfg-duplicate-language-validation
branch
from
133312f to
c89159f
Compare
joaodinissf
changed the title
joaodinissf
force-pushed
the
fix/checkcfg-duplicate-language-validation
branch
from
c89159f to
4bd5ca1
Compare
auto-merge was automatically disabled
June 12, 2026 21:07
Pull request was converted to draft
joaodinissf
force-pushed
the
fix/checkcfg-duplicate-language-validation
branch
2 times, most recently
from
fdcf350 to
01559a7
Compare
joaodinissf
changed the title
joaodinissf
force-pushed
the
fix/checkcfg-duplicate-language-validation
branch
from
7133f27 to
d9d4b7f
Compare
The CHECKCFG grammar accepts multiple `for <Language> { ... }` blocks for
the same language in one configuration, with no defined semantics for how
duplicates combine. CheckCfgValidator.checkConfiguredLanguageUnique now
reports an error on each ConfiguredLanguageValidator that shares a
language name with another, mirroring the existing catalog/check/parameter
uniqueness validators and reusing the getDuplicates() helper. Covered by
CheckCfgTest.testDuplicateLanguageNotOk.
Validation only, no quick-fix: a merge quick-fix cannot preserve generated
output. Language-level parameters are inherited by inner catalogs and
checks, and the properties generator resolves them first-wins per section,
so collapsing two blocks into one silently changes which value inner
catalogs inherit. The correct resolution depends on author intent, so the
error guides the user to resolve duplicates manually.
Language-scoped catalog/check/parameter uniqueness inside a single
language block is a pre-existing validation gap left as a follow-up.
Closes dsldevkit#103
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018ANGM7L3BaEGfGUmPVKRt4
joaodinissf
force-pushed
the
fix/checkcfg-duplicate-language-validation
branch
from
d9d4b7f to
662b6ee
Compare
rubenporras
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an error-severity validation that flags duplicate language configurations in a CHECKCFG file.
The grammar accepts multiple
for <Language> { ... }blocks in one configuration, with no defined semantics for how duplicates combine.CheckCfgValidator.checkConfiguredLanguageUniquenow reports an error on eachConfiguredLanguageValidatorthat shares a language name with another, mirroring the existing catalog/check/parameter uniqueness validators and reusing thegetDuplicates()helper. Covered byCheckCfgTest.testDuplicateLanguageNotOk.Validation only, no quick-fix: a quick-fix would have to merge the duplicate blocks, which cannot preserve generated output. Language-level parameters are inherited by inner catalogs/checks and the generator resolves them first-wins per section, so collapsing two blocks into one silently changes which value inner catalogs inherit. The correct resolution depends on author intent, so the error guides the user to resolve duplicates manually.
Note: uniqueness of catalogs configured inside
for <Language>blocks (checkConfiguredCatalogUniqueonly covers the legacy top-level catalog configurations) and of section-level parameters is a pre-existing validation gap, left as a follow-up.Closes #103
🤖 Generated with Claude Code